zjuwangg commented on code in PR #10659:
URL:
https://github.com/apache/incubator-gluten/pull/10659#discussion_r2340668743
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -538,6 +538,7 @@ object VeloxConfig {
val VELOX_BROADCAST_BUILD_RELATION_USE_OFFHEAP =
buildConf("spark.gluten.velox.offHeapBroadcastBuildRelation.enabled")
.internal()
+ .experimental()
Review Comment:
> Possible rule
>
> Public/internal: Who should see/use it
> Experimental: How reliable it is (can be marked as either public or
internal based on the first item)
I second this idea.
> Then, I feel it may be not good to have a dedicated section to document
experimental configs, considering possible duplication
Maybe we also can only list public config but add a `experimental` flag in
such config to avoid duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
