zhli1142015 commented on code in PR #9058:
URL: https://github.com/apache/incubator-gluten/pull/9058#discussion_r2384521180
##########
cpp/velox/operators/serializer/VeloxColumnarToRowConverter.cc:
##########
@@ -70,7 +70,7 @@ void
VeloxColumnarToRowConverter::refreshStates(facebook::velox::RowVectorPtr ro
void VeloxColumnarToRowConverter::convert(std::shared_ptr<ColumnarBatch> cb,
int64_t startRow) {
auto veloxBatch = VeloxColumnarBatch::from(veloxPool_.get(), cb);
- refreshStates(veloxBatch->getRowVector(), startRow);
Review Comment:
Hello @WangGuangxin
Could you point out why we need to replace getRowVector with
getFlattenedRowVector here? My understanding is that UnsafeRowFast will wrap
the passed-in vector into a DecodedVector which can handle all encodings, so
there should be no need to call getFlattenedRowVector here — and
getFlattenedRowVector may introduce extra vector copy operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
