zhli1142015 commented on code in PR #9058:
URL: https://github.com/apache/incubator-gluten/pull/9058#discussion_r2389482034


##########
cpp/velox/operators/serializer/VeloxColumnarToRowConverter.cc:
##########
@@ -70,7 +70,7 @@ void 
VeloxColumnarToRowConverter::refreshStates(facebook::velox::RowVectorPtr ro
 
 void VeloxColumnarToRowConverter::convert(std::shared_ptr<ColumnarBatch> cb, 
int64_t startRow) {
   auto veloxBatch = VeloxColumnarBatch::from(veloxPool_.get(), cb);
-  refreshStates(veloxBatch->getRowVector(), startRow);

Review Comment:
   cc @jinchengchenghh 
   Do you have any comments for this question?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to