jiangjiangtian commented on code in PR #10637:
URL:
https://github.com/apache/incubator-gluten/pull/10637#discussion_r2450873133
##########
backends-velox/src/main/scala/org/apache/gluten/execution/ColumnarPartialProjectExec.scala:
##########
@@ -50,7 +54,9 @@ import scala.collection.mutable.ListBuffer
* @param child
* child plan
*/
-case class ColumnarPartialProjectExec(projectList: Seq[NamedExpression],
child: SparkPlan)(
+case class ColumnarPartialProjectExec(
+ projectList: Seq[Expression],
+ child: SparkPlan,
replacedAlias: Seq[Alias])
Review Comment:
Because after this PR, `SubQuery` may be replaced. If `replacedAlias` is not
put into the first argument list, then
[prepareSubqueries](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala#L274-L282)
can't find the subquery in `replacedAlias`. So I put it in the first argument
list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
