jinchengchenghh commented on code in PR #10637:
URL:
https://github.com/apache/incubator-gluten/pull/10637#discussion_r2451467605
##########
backends-velox/src/main/scala/org/apache/gluten/execution/ColumnarPartialProjectExec.scala:
##########
@@ -50,7 +54,9 @@ import scala.collection.mutable.ListBuffer
* @param child
* child plan
*/
-case class ColumnarPartialProjectExec(projectList: Seq[NamedExpression],
child: SparkPlan)(
+case class ColumnarPartialProjectExec(
+ projectList: Seq[Expression],
+ child: SparkPlan,
replacedAlias: Seq[Alias])
Review Comment:
The Alias is unique, with this change, the exprId is different, and the
alias origins from projectList, the subquery should be found from it.
##########
backends-velox/src/main/scala/org/apache/gluten/execution/ColumnarPartialProjectExec.scala:
##########
@@ -349,13 +351,115 @@ object ColumnarPartialProjectExec {
}
}
+ private def doNativeValidateExpression(
+ expr: Expression,
+ replacedAlias: ListBuffer[Alias],
+ childOutput: Seq[Attribute]): Boolean = {
+ val substraitContext = new SubstraitContext
+ val output = childOutput ++ replacedAlias.map(_.toAttribute)
+ val exprTransformer =
ExpressionConverter.replaceWithExpressionTransformer(expr, output)
Review Comment:
Here may throw exception for function name not mapping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
