PHILO-HE commented on code in PR #10999:
URL:
https://github.com/apache/incubator-gluten/pull/10999#discussion_r2485616152
##########
gluten-iceberg/src/main/scala/org/apache/gluten/execution/IcebergScanTransformer.scala:
##########
@@ -253,7 +253,7 @@ object IcebergScanTransformer {
}
def supportsBatchScan(scan: Scan): Boolean = {
- scan.getClass.getName ==
"org.apache.iceberg.spark.source.SparkBatchQueryScan"
+ scan.getClass == GlutenIcebergSourceUtil.getClassOfSparkBatchQueryScan
Review Comment:
@Zouxxyy Thanks for the review.
The logic remains identical to the previous implementation by explicitly
excluding inherited relationships. Since `SparkBatchQueryScan` has no subclass,
I think this check for strict equality looks better for us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
