PHILO-HE commented on PR #10999: URL: https://github.com/apache/incubator-gluten/pull/10999#issuecomment-3479644111
> > With runtime-compatibility validation introduced by #10942 for component, we can safely use class references in components modules. > > The change of this PR looks good, but I am trying to understand why #10942 is required for this PR. As far as I understand, no matter a component is valid or not, error will be thrown when we are trying to access a class that is not present in class path by reference. No? @zhztheplayer, thanks for the review. Here are some historical discussions: https://github.com/apache/incubator-gluten/pull/10900#discussion_r2446868970 https://github.com/apache/incubator-gluten/pull/10186#discussion_r2280763905 In the component validation, we checked the presence of a core class in the classpath, assuming that other classes in the corresponding JAR would also be available. While there are some rare edge cases (which likely requires fixes) that violates this, I think we can ignore them here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
