marin-ma commented on code in PR #11392:
URL:
https://github.com/apache/incubator-gluten/pull/11392#discussion_r2682007151
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -447,6 +447,18 @@ object VeloxConfig extends ConfigRegistry {
.longConf
.createWithDefault(4194304L)
+ val COLUMNAR_VELOX_HASH_PROBE_DYNAMIC_FILTER_PUSHDOWN_ENABLED =
+
buildConf("spark.gluten.sql.columnar.backend.velox.hash_probe_bloom_filter_pushdown_max_size")
+ .doc("The maximum byte size of Bloom filter that can be generated from
hash probe. When set to 0, no Bloom filter will be generated. To achieve
optimal performance, this should not be too larger than the CPU cache size on
the host.")
+ .intConf
+ .createWithDefault(0)
Review Comment:
Seems like the variable name and the configuration don't match.
```
val COLUMNAR_VELOX_HASH_PROBE_DYNAMIC_FILTER_PUSHDOWN_ENABLED =
buildConf("spark.gluten.sql.columnar.backend.velox.hash_probe_bloom_filter_pushdown_max_size")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
