marin-ma commented on code in PR #11392:
URL:
https://github.com/apache/incubator-gluten/pull/11392#discussion_r2685610892
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -447,6 +451,21 @@ object VeloxConfig extends ConfigRegistry {
.longConf
.createWithDefault(4194304L)
+ val COLUMNAR_VELOX_HASH_PROBE_BLOOM_FILTER_PUSHDOWN_MAX_SIZE =
+
buildConf("spark.gluten.sql.columnar.backend.velox.hash_probe_bloom_filter_pushdown_max_size")
Review Comment:
+1 Let's follow the camel case naming for the newly added configurations. If
the configuration name is too long, you can break it into multiple parts. e.g.
`.hashProbe.bloomFilterPushDownMaxSize`
For the variable name, please shorten it to
`HASH_PROBE_BLOOM_FILTER_PUSHDOWN_MAX_SIZE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
