acvictor opened a new pull request, #11636:
URL: https://github.com/apache/incubator-gluten/pull/11636
## What changes are proposed in this pull request?
This PR replaces `new` allocation of `VarChar` sub-messages with
`Arena::CreateMessage` to match the arena-allocated parent in
`VeloxToSubstraitExpr.cc`. When a protobuf message is arena-allocated, its
destructor never runs so children attached via `set_allocated_*` that were
heap-allocated with `new` are never deleted. Every other sub-message in this
file already uses
`Arena::CreateMessage` correctly and `VarChar` was the only exception.
## How was this patch tested?
Existing UTs
## Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
