wecharyu commented on code in PR #11637:
URL:
https://github.com/apache/incubator-gluten/pull/11637#discussion_r2894539956
##########
backends-velox/src/main/scala/org/apache/gluten/extension/PartialProjectRule.scala:
##########
@@ -30,24 +30,24 @@ case class PartialProjectRule(spark: SparkSession) extends
Rule[SparkPlan] {
return plan
}
- val newPlan = plan match {
- // If the root node of the plan is a ProjectExec and its child is a
gluten columnar op,
- // we try to add a ColumnarPartialProjectExec
- case p: ProjectExec if PlanUtil.isGlutenColumnarOp(p.child) =>
- tryAddColumnarPartialProjectExec(p)
- case _ => plan
- }
+ // Wrap a WholeStageTransformer to check if the top node supports partial
fallback.
+ // It will be removed afterward.
+ val newPlan = WholeStageTransformer(plan)(-1)
Review Comment:
No, the top node's child may also supports partial fallback, if we check top
node before check the child, the top node will not be able to convert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
