wecharyu opened a new pull request, #11637:
URL: https://github.com/apache/incubator-gluten/pull/11637

   ## What changes are proposed in this pull request?
   Fix https://github.com/apache/incubator-gluten/issues/11635
   
   ## How was this patch tested?
   
   Add a new unit test.
   ```sql
   select plus_one(col1) as col2, l_partkey from (
     select plus_one(l_orderkey) as col1, l_partkey from lineitem
   )
   ```
   
   Before this PR:
   ```bash
   == Physical Plan ==
   *(1) Project [if (isnull(col1#73L)) null else 
plus_one(knownnotnull(col1#73L)) AS col2#74L, l_partkey#1L]
   +- *(1) Project [if (isnull(l_orderkey#0L)) null else 
plus_one(knownnotnull(l_orderkey#0L)) AS col1#73L, l_partkey#1L]
      +- VeloxColumnarToRow
         +- ^(1) BatchScanExecTransformer parquet 
file:/root/workspace/gluten-community/backends-velox/target/scala-2.13/test-classes/tpch-data-parquet/lineitem[l_orderkey#0L,
 l_partkey#1L] ParquetScan DataFilters: [], Format: parquet, Location: 
InMemoryFileIndex(1 
paths)[file:/root/workspace/gluten-community/backends-velox/target/scala-2.13...,
 PartitionFilters: [], PushedAggregation: [], PushedFilters: [], PushedGroupBy: 
[], ReadSchema: struct<l_orderkey:bigint,l_partkey:bigint> RuntimeFilters: [] 
NativeFilters: []
   ```
   
   After this PR:
   ```bash
   VeloxColumnarToRow
   +- ^(3) ProjectExecTransformer [_SparkPartialProject0#56L AS col2#38L, 
l_partkey#1L]
      +- ^(3) InputIteratorTransformer[col1#37L, l_partkey#1L, 
_SparkPartialProject0#56L]
         +- ColumnarPartialProject [if (isnull(col1#37L)) null else 
plus_one(knownnotnull(col1#37L)) AS col2#38L, l_partkey#1L] PartialProject 
List(if (isnull(col1#37L)) null else plus_one(knownnotnull(col1#37L)) AS 
_SparkPartialProject0#56L)
            +- ^(2) ProjectExecTransformer [_SparkPartialProject0#55L AS 
col1#37L, l_partkey#1L]
               +- ^(2) InputIteratorTransformer[l_orderkey#0L, l_partkey#1L, 
_SparkPartialProject0#55L]
                  +- ColumnarPartialProject [if (isnull(l_orderkey#0L)) null 
else plus_one(knownnotnull(l_orderkey#0L)) AS col1#37L, l_partkey#1L] 
PartialProject List(if (isnull(l_orderkey#0L)) null else 
plus_one(knownnotnull(l_orderkey#0L)) AS _SparkPartialProject0#55L)
                     +- ^(1) BatchScanExecTransformer parquet 
file:/root/workspace/gluten-community/backends-velox/target/scala-2.13/test-classes/tpch-data-parquet/lineitem[l_orderkey#0L,
 l_partkey#1L] ParquetScan DataFilters: [], Format: parquet, Location: 
InMemoryFileIndex(1 
paths)[file:/root/workspace/gluten-community/backends-velox/target/scala-2.13...,
 PartitionFilters: [], PushedAggregation: [], PushedFilters: [], PushedGroupBy: 
[], ReadSchema: struct<l_orderkey:bigint,l_partkey:bigint> RuntimeFilters: [] 
NativeFilters: []
   ```
   
   ## Was this patch authored or co-authored using generative AI tooling?
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to