zhztheplayer commented on PR #12028: URL: https://github.com/apache/gluten/pull/12028#issuecomment-4407860724
> For SparkPlan nodes that lack a logicalLink (e.g., SortExec / BroadcastExchange generated by EnsureRequirements), GlutenFallbackReporter cannot copy their FallbackTag onto a logical plan, Just curious, does this behavior differ across Spark versions? I checked latest Spark code and the rule adopts `transformUp` which should've copied logical links to the sort / exchange nodes: https://github.com/apache/spark/blob/484bb5b2cd718d27872235a30c1af69d5d4d34d7/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala#L891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
