liujiayi771 commented on PR #12028: URL: https://github.com/apache/gluten/pull/12028#issuecomment-4408114556
@zhztheplayer You're right that `EnsureRequirements.apply` uses `transformUp`, but `transformUp` only carries over tags (including logicalLink) to the node being directly replaced via `copyTagsFrom`. It does NOT set logicalLink on newly constructed child nodes. In `ensureDistributionAndOrdering`, the new `SortExec(...)` / `ShuffleExchangeExec(...)` / `BroadcastExchangeExec(...)` are created directly without any `setLogicalLink` call. The `transformUp` rule matches the parent operator (e.g., SMJ) and calls `reordered.withNewChildren(newChildren)`, which preserves the parent's logicalLink but does not propagate it to the newly inserted children. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
