Yao-MR commented on PR #12059: URL: https://github.com/apache/gluten/pull/12059#issuecomment-4494158772
> > The following code may also need updating. Could you check if there are other places that need changes as well? Thank you. > > https://github.com/philo-he/gluten/blob/6fa6062a92f6dbd320a77ab6075f67f5d92ba97e/dev/docker/Dockerfile.centos8-dynamic-build#L35 > > https://github.com/philo-he/gluten/blob/6fa6062a92f6dbd320a77ab6075f67f5d92ba97e/.github/workflows/util/setup-helper.sh#L21 > > sure,will overall check. Thanks @philo-he for the careful review! I checked the whole repo and here is what I found: Already updated in this PR (only the places needed for Spark 4.1) pom.xml: <maven.version> 3.9.13 → 3.9.15 dev/vcpkg/setup-build-depends.sh: maven_version → 3.9.15 About the two files you pointed out Both links point to my fork at commit 6fa6062 where the line numbers were valid. After rebasing onto the latest main: dev/docker/Dockerfile.centos8-dynamic-build no longer has an apache-maven-*-bin.tar.gz install step on the latest main — it relies on the build/mvn wrapper, so nothing to update there. .github/workflows/util/setup-helper.sh no longer exists in the current main branch. So those two specific locations are no longer applicable. Other Maven 3.6.3 references I found but intentionally left unchanged tools/gluten-te/{ubuntu,centos}/dockerfile-build: the apache-maven-3.6.3 download is gated behind JDK_DEBUG_BUILD=ON (a custom OpenJDK 8 fastdebug image) and the build is hard-pinned to -Pspark-3.5. It never participates in the Spark 4.1 build path, so bumping it would be out of scope for this PR. <requireMavenVersion>3.6.3</requireMavenVersion> in pom.xml and package/pom.xml: matches the upstream Spark approach in apache/spark#55398 — only <maven.version> (the build/mvn wrapper hint) is bumped while the enforcer floor is kept, so users still building Spark 3.3/3.4/3.5 with Maven 3.6.x/3.8.x are not broken. Happy to bump any of these if you'd prefer fully unifying on 3.9.15 — just want to keep the PR focused on what Spark 4.1 actually requires. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
