Yao-MR commented on PR #12059: URL: https://github.com/apache/gluten/pull/12059#issuecomment-4494173344
> > The following code may also need updating. Could you check if there are other places that need changes as well? Thank you. > > https://github.com/philo-he/gluten/blob/6fa6062a92f6dbd320a77ab6075f67f5d92ba97e/dev/docker/Dockerfile.centos8-dynamic-build#L35 > > https://github.com/philo-he/gluten/blob/6fa6062a92f6dbd320a77ab6075f67f5d92ba97e/.github/workflows/util/setup-helper.sh#L21 > > sure,will overall check. Thanks @philo-he for the careful review. I went through the whole repo and here's the status. Already updated in this PR: - pom.xml: <maven.version> 3.9.13 -> 3.9.15 - dev/vcpkg/setup-build-depends.sh: maven_version -> 3.9.15 About the two files you pointed out: The links reference my fork at an older commit. After rebasing onto the latest main: - dev/docker/Dockerfile.centos8-dynamic-build no longer installs apache-maven-*-bin.tar.gz directly; it relies on the build/mvn wrapper, so nothing to change there. - .github/workflows/util/setup-helper.sh no longer exists on main. Other Maven 3.6.3 references I found but intentionally left unchanged: 1. tools/gluten-te/ubuntu/dockerfile-build and tools/gluten-te/centos/dockerfile-build The apache-maven-3.6.3 download is gated behind JDK_DEBUG_BUILD=ON (a custom OpenJDK 8 fastdebug image) and the build is hard-pinned to -Pspark-3.5. It does not participate in the Spark 4.1 build path, so bumping it would expand the scope of this PR without any functional benefit. 2. <requireMavenVersion>3.6.3</requireMavenVersion> in pom.xml and package/pom.xml This matches upstream Spark (apache/spark#55398): only <maven.version> (the build/mvn wrapper hint) is bumped, while the enforcer floor is kept so users still building Spark 3.3 / 3.4 / 3.5 with Maven 3.6.x or 3.8.x are not broken. Spark 4.1's hard requirement is JDK 17 + Scala 2.13, not a Maven minimum. In short, the scope of this PR only covers the places Spark 4.1 actually requires; the legacy Spark 3.x build paths keep their existing Maven floor for backward compatibility, following the same approach as upstream Spark. Happy to bump the remaining references to 3.9.15 if you'd prefer full unification. Let me know your preference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
