Copilot commented on code in PR #11712: URL: https://github.com/apache/gluten/pull/11712#discussion_r3476336820
########## ep/build-velox/src/get-velox.sh: ########## @@ -18,7 +18,7 @@ set -exu CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd) VELOX_REPO=https://github.com/IBM/velox.git -VELOX_BRANCH=dft-2026_06_12 +VELOX_BRANCH=dft-2026_06_23-new VELOX_ENHANCED_BRANCH=ibm-2026_06_12 Review Comment: `VELOX_BRANCH` was changed to `dft-2026_06_23-new`, which breaks the existing date-only naming pattern used here previously (`dft-YYYY_MM_DD`) and makes it unclear whether this is a stable rebase point or a temporary/testing branch. Also, `--enable_enhanced_features=ON` will switch to `VELOX_ENHANCED_BRANCH=ibm-2026_06_12`, which is now older than the default `VELOX_BRANCH`; if intentional, it should be documented here to avoid surprising build results, otherwise the enhanced branch/tag likely needs to be updated in sync with the default rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
