Copilot commented on code in PR #11712:
URL: https://github.com/apache/gluten/pull/11712#discussion_r3480402159
##########
cpp/velox/utils/VeloxWriterUtils.h:
##########
@@ -23,7 +23,7 @@
namespace gluten {
-std::unique_ptr<facebook::velox::parquet::WriterOptions>
makeParquetWriteOption(
+std::unique_ptr<facebook::velox::dwio::common::WriterOptions>
makeParquetWriteOption(
Review Comment:
The declaration of makeParquetWriteOption now returns
dwio::common::WriterOptions, but the implementation in
cpp/velox/utils/VeloxWriterUtils.cc returns std::unique_ptr<WriterOptions>
where WriterOptions is from facebook::velox::parquet (via using namespace).
There are also call sites that expect parquet::WriterOptions (e.g.,
SubstraitToVeloxPlan.cc uses
std::shared_ptr<facebook::velox::parquet::WriterOptions>). As-is, this header
change will break compilation due to a signature mismatch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
