minni31 commented on code in PR #12242:
URL: https://github.com/apache/gluten/pull/12242#discussion_r3534137602
##########
gluten-ut/spark41/src/test/scala/org/apache/spark/sql/GlutenBitmapExpressionsQuerySuite.scala:
##########
@@ -37,4 +37,19 @@ class GlutenBitmapExpressionsQuerySuite
"Expected native HashAggregateExecBaseTransformer in plan"
)
}
+
+ test("bitmap_or_agg routes to native") {
+ val df = spark.sql(
+ "SELECT bitmap_or_agg(bm) FROM (" +
+ "SELECT bitmap_construct_agg(bitmap_bit_position(col)) AS bm " +
+ "FROM values (1L), (2L), (3L) AS t(col)" +
+ ") sub")
+ df.collect()
+ assert(
+ collectWithSubqueries(df.queryExecution.executedPlan) {
+ case h: HashAggregateExecBaseTransformer => h
+ }.nonEmpty,
+ "Expected native HashAggregateExecBaseTransformer in plan"
+ )
+ }
Review Comment:
Good catch — this was fixed in commit "Fix nested aggregate in
bitmap_or_agg test SQL". The query now uses a subquery (SELECT
bitmap_or_agg(bm) FROM (SELECT bitmap_construct_agg(...) AS bm ...) sub) to
avoid nesting aggregates at the same level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
