Copilot commented on code in PR #12400:
URL: https://github.com/apache/gluten/pull/12400#discussion_r3558642201
##########
ep/build-velox/src/get-velox.sh:
##########
@@ -159,6 +159,22 @@ function apply_compilation_fixes {
$SUDO_CMD cp ${CURRENT_DIR}/modify_arrow.patch
${VELOX_HOME}/CMake/resolve_dependency_modules/arrow/
git add
${VELOX_HOME}/CMake/resolve_dependency_modules/arrow/modify_arrow.patch # to
avoid the file from being deleted by git clean -dffx :/
+
+ # Wire file handle cache TTL config to SimpleLRUCache constructor.
Review Comment:
In apply_compilation_fixes, the `cp` and `git add` lines still use unquoted
`${CURRENT_DIR}` / `${VELOX_HOME}` expansions. If these paths ever contain
spaces (e.g., custom workspaces), this will fail or apply the patch to the
wrong location. Quote the path arguments consistently (the new TTL patch block
already does).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
