Smallfu666 commented on PR #12610:
URL: https://github.com/apache/gluten/pull/12610#issuecomment-5062289134
CI is green (50 checks passed, only the unrelated `tpc-test-ubuntu-oom`
stress job still running), and the Stash restore path is confirmed working end
to end on this PR's own runs.
**First run** surfaced a real gap: the `stash/restore` action shells out to
`gh` and `jq`, which the `vcpkg-centos-9` / `centos-9-jdk8` **container** jobs
don't ship (host-runner jobs already have them). Fixed in 30b26aab6 by
installing pinned static `gh`/`jq` before the restore step in the three
container jobs.
**Rerun evidence** — `build-native-lib-centos-8` (ARM64, container):
```
Downloading stash (attempt 1 of 3)... # key
ccache-centos8-release-default-ARM64-44d6af32...
stash-hit=true # ~13s download
Successfully built Velox from Source. # build step total ~90s
ccache stats: Hits: 101618 / 107649 (94.40 %)
Hits: 206561 / 213278 (96.85 %)
```
So the full chain works: producer seed on `apache/main` (#12602) -> consumer
`stash/restore` on this PR -> `stash-hit=true` -> ~94% ccache hit -> the native
build drops from a cold ~1h to ~2m35s.
As noted in the PR description, the consumer-side `actions/cache` **save**
steps are intentionally left in place for instant rollback; removing the legacy
`actions/cache` producer + consumer code is the final cleanup stage of #12599,
which I'll open once this lands.
One follow-up worth considering separately: adding `gh`/`jq` to the
`apache/gluten` CI container images would let us drop the per-job install step
here and in any future Stash consumers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
