Smallfu666 commented on PR #12610: URL: https://github.com/apache/gluten/pull/12610#issuecomment-5068756432
Thanks @zhouyuan, that's a better design. You're right that Stash has no restore-keys, so a changed `ep/build-velox/src` tree misses and cold-builds, whereas `actions/cache`'s restore-keys can still pull the latest cache on main. I'll combine them for x86/arm/enhanced: keep the Stash restore first, then add an `actions/cache/restore` with restore-keys as a fallback when `stash-hit` is false, and keep the `actions/cache` save so both stay populated. I'll revert the producer / nightly / bundle changes so the legacy cache method stays as-is there. Updating the PR shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
