rui-mo commented on PR #12605: URL: https://github.com/apache/gluten/pull/12605#issuecomment-5216291697
> The regression matrix and benchmark results in this PR should be reusable for validating the upstream fix, including the reported DECIMAL(38,19) case and the values around the double precision boundary. @Smallfu666 Thanks for your understanding! Agreed — those tests would be very useful. I reached out to the author of https://github.com/facebookincubator/velox/pull/12512, and he’s willing to follow up on that PR to address the precision issue in Velox. Once that fix lands, we can proceed with this PR and enable those tests. cc: @kecookier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
