rui-mo commented on PR #12605: URL: https://github.com/apache/gluten/pull/12605#issuecomment-5495744645
Hi @Smallfu666, The relevant Velox fix https://github.com/facebookincubator/velox/pull/12512 has been merged. It introduces an opt-in configuration for high-precision DECIMAL-to-REAL/DOUBLE casts. Would you like to revise this PR to: - Add a Gluten configuration that maps to Velox’s high-precision cast configuration, so users who are sensitive to precision loss can explicitly enable this behavior. - Keep the unit tests in this PR and run the high-precision cast tests with this configuration enabled. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
