rui-mo commented on code in PR #12656:
URL: https://github.com/apache/gluten/pull/12656#discussion_r3854278030
##########
gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/validator/Validators.scala:
##########
@@ -284,7 +284,9 @@ object Validators {
case Second(child, _) => containsNTZ(child.dataType)
case TimestampAdd(_, _, child, _) =>
containsNTZ(child.dataType)
case c: Cast if c.dataType == TimestampType =>
isNTZ(c.child.dataType)
- case c: Cast if isNTZ(c.dataType) => c.child.dataType ==
TimestampType
+ case c: Cast if c.dataType == StringType =>
isNTZ(c.child.dataType)
+ case c: Cast if isNTZ(c.dataType) =>
+ c.child.dataType == TimestampType || c.child.dataType ==
StringType
Review Comment:
I assume we won't need the additional validation on the Scala side if we
move these checks into `isAllowedCast`. They serve the same purpose: validating
the plan before execution and falling back when the cast is unsupported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
