Copilot commented on code in PR #12626:
URL: https://github.com/apache/gluten/pull/12626#discussion_r3859791263
##########
gluten-delta/src/main/scala/org/apache/gluten/execution/DeltaScanTransformer.scala:
##########
@@ -166,6 +167,20 @@ case class DeltaScanTransformer(
override def withNewPushdownFilters(filters: Seq[Expression]):
BasicScanExecTransformer =
copy(pushDownFilters = Some(filters))
+
+ // Vanilla Delta CDF translates V1 filters with nested-predicate pushdown
disabled.
+ override protected def supportNestedPredicatePushdownForDisplay: Boolean = {
+ if (isCdfScan) {
+ false
+ } else {
+ super.supportNestedPredicatePushdownForDisplay
+ }
+ }
+
+ private def isCdfScan: Boolean = relation.location match {
+ case _: CdcAddFileIndex | _: TahoeRemoveFileIndex | _:
TahoeChangeFileIndex => true
+ case _ => false
+ }
Review Comment:
The new CDF-specific override of `supportNestedPredicatePushdownForDisplay`
isn’t covered by a test that exercises `DeltaScanTransformer` (current
`DeltaPushedFiltersDisplaySuite` only asserts Spark’s
`DataSourceStrategy.translateFilter` behavior). This makes it easy for future
refactors to break the CDF explain-output quoting/backtick behavior without a
regression signal. Add a delta integration/unit test that constructs a CDF scan
and asserts the `PushedFilters` rendering uses the non-nested translation (no
identifier quoting) while preserving literal backticks in values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
