felipepessoto commented on PR #12626:
URL: https://github.com/apache/gluten/pull/12626#issuecomment-5434346693
@zhztheplayer yes, Spark adds * only for RowDataSourceScanExec . This PR
extends that convention to Gluten’s FileSourceScanExecTransformer because the
native scan performs exact row filtering and the post-scan filter becomes
unnecessary.
However, this is only a plan-display improvement, NativeFilters already
exposes the native predicates, and supporting it requires five Spark shims plus
785 golden updates.
Do you think Gluten should generalize * based on handled-filter semantics,
or should we keep Spark’s operator-specific convention and close this PR? I’m
leaning toward closing it to avoid so many changes only to improve the plan
display, unless maintainers see enough value in the semantic parity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
