zhztheplayer commented on code in PR #12981:
URL: https://github.com/apache/gluten/pull/12981#discussion_r3965372207
##########
backends-clickhouse/src/test/scala/org/apache/gluten/execution/GlutenClickHouseWholeStageTransformerSuite.scala:
##########
@@ -155,15 +154,16 @@ class GlutenClickHouseWholeStageTransformerSuite
final override protected val resourcePath: String = "" // ch not need this
override protected val fileFormat: String = "parquet"
- protected def testSparkVersionLE33(testName: String, testTag: Tag*)(testFun:
=> Any): Unit = {
- if (isSparkVersionLE("3.3")) {
- test(testName, testTag: _*)(testFun)
- } else {
- ignore(s"[$SPARK_VERSION_SHORT]-$testName", testTag: _*)(testFun)
- }
+ /**
+ * These cases only ever passed on Spark 3.3, which is no longer supported.
They are registered as
+ * ignored rather than deleted so that they stay visible in the test report
until someone either
+ * makes them pass on a supported version or removes them.
+ */
+ protected def ignoreSpark33OnlyCase(testName: String, testTag:
Tag*)(testFun: => Any): Unit = {
Review Comment:
cc @zzcclp
##########
backends-clickhouse/src-kafka/test/scala/org/apache/gluten/execution/kafka/ClickhouseGlutenKafkaScanSuite.scala:
##########
@@ -104,7 +104,7 @@ class ClickhouseGlutenKafkaScanSuite
}
// TODO: after rebase-25.12, failed with spark35 (0 did not equal 100000),
fix later
- testWithSpecifiedSparkVersion("GLUTEN-9681: test kafka data consistency",
"3.3") {
+ ignore("GLUTEN-9681: test kafka data consistency") {
Review Comment:
Can we also put the reason for ignoring in a comment before the test case?
##########
backends-clickhouse/src/test/scala/org/apache/gluten/execution/hive/GlutenClickHouseHiveTableSuite.scala:
##########
@@ -1038,25 +1038,13 @@ class GlutenClickHouseHiveTableSuite
spark.sql(
s"CREATE FUNCTION my_add as " +
s"'org.apache.hadoop.hive.contrib.udf.example.UDFExampleAdd2' USING
JAR '$jarUrl'")
- if (isSparkVersionLE("3.3")) {
- runQueryAndCompare("select MY_ADD(id, id+1) from range(10)")(
- checkGlutenPlan[ProjectExecTransformer])
- } else {
- runQueryAndCompare("select MY_ADD(id, id+1) from range(10)", noFallBack
= false)(_ => {})
- }
+ runQueryAndCompare("select MY_ADD(id, id+1) from range(10)", noFallBack =
false)(_ => {})
}
+ // TODO: the expected operator counts at the call sites below only held on
Spark 3.3. Re-derive
Review Comment:
`checkOperatorCount` looks removable now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
