LuciferYang commented on code in PR #12981:
URL: https://github.com/apache/gluten/pull/12981#discussion_r3969486128
##########
backends-clickhouse/src/test/scala/org/apache/gluten/execution/tpch/GlutenClickHouseTPCHParquetRFSuite.scala:
##########
@@ -55,19 +53,7 @@ class GlutenClickHouseTPCHParquetRFSuite extends
GlutenClickHouseTPCHSaltNullPar
|
|""".stripMargin,
compareResult = true,
- df => {
- if (spark33) {
- val filterExecs = df.queryExecution.executedPlan.collect {
- case filter: FilterExecTransformerBase => filter
- }
- assert(filterExecs.size == 4)
- assert(
- filterExecs.head
- .asInstanceOf[FilterExecTransformer]
- .toString
- .contains("might_contain"))
- }
- }
+ NOOP
Review Comment:
This one does not hold. `NOOP` is not provided by the wildcard import I
removed: it is `val NOOP: DataFrame => Unit = _ => {}` in `trait withTPCHQuery`
at `GlutenClickHouseTPCHAbstractSuite.scala:159`, and this suite inherits it
through `GlutenClickHouseTPCHSaltNullParquetSuite`. The import I dropped was
`org.apache.gluten.execution._`, which had become unused once the
`FilterExecTransformer` assertions inside `if (spark33)` went away.
`test-compile` for the ClickHouse backend on 3.5 passes, which is the check
that would catch it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
