LuciferYang commented on code in PR #12981:
URL: https://github.com/apache/gluten/pull/12981#discussion_r3976122159
##########
backends-clickhouse/src-iceberg/test/scala/org/apache/gluten/execution/iceberg/ClickHouseIcebergMOREqualityDeletionSuite.scala:
##########
@@ -60,7 +60,7 @@ class ClickHouseIcebergMOREqualityDeletionSuite extends
GlutenClickHouseWholeSta
FileUtils.copyDirectory(equalityDeletedData, icebergPathDir)
}
- testWithSpecifiedSparkVersion("iceberg read mor table with equality
deletion", "3.3", "3.5") {
+ testWithSpecifiedSparkVersion("iceberg read mor table with equality
deletion", "3.5") {
Review Comment:
Good catch, and it reaches further than this file:
`testWithMinSparkVersion(..., "3.4")` is constant-true now that 3.4 is the
minimum, which is the same thing as the twelve `isSparkVersionGE("3.4")` checks
this PR already collapses. I missed the helper form.
Counted 57 such call sites across 15 files, mostly the velox
`*ValidateSuite` set plus the three iceberg suites, `DeltaSuite`,
`MiscOperatorSuite` and `FallbackSuite`. The other 14 sites pass `"3.5"`,
`"4.0"` or `"4.1"` and stay as they are, so the helper itself is still needed.
I will do it as a separate follow-up rather than here. This PR is already
approved and spans seven modules with five rounds of review comments; adding 57
mechanical edits would invalidate the approval and ask everyone to re-read the
whole thing. As its own PR it is one substitution repeated 57 times, which is
much easier to scan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
