philo-he commented on code in PR #12976:
URL: https://github.com/apache/gluten/pull/12976#discussion_r4010710202
##########
backends-velox/src/test/scala/org/apache/gluten/execution/MiscOperatorSuite.scala:
##########
@@ -2342,7 +2342,7 @@ class MiscOperatorSuite extends
VeloxWholeStageTransformerSuite with AdaptiveSpa
test("Expression unsupported by backend can be handled by
ColumnarPartialProject") {
runQueryAndCompare(
- "SELECT c_custkey, map_from_arrays(array(c_name), array(c_comment)) FROM
customer") {
+ "SELECT c_custkey, c_name, sequence(c_custkey, c_custkey + 2) FROM
customer") {
Review Comment:
This original test is fragile since it depends on that one of the
expressions in use is not supported. But once it is supported, the test will
fail.
I think the following test already guards the basic functionality of
ColumnarPartialProject, so perhaps we can remove the above test.
https://github.com/pedrumj2/gluten/blob/84a2b7a5737744d9ffb75e5548d7a638d58b4175/backends-velox/src/test/scala/org/apache/gluten/execution/MiscOperatorSuite.scala#L2221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
