pedrumj2 commented on PR #12976: URL: https://github.com/apache/gluten/pull/12976#issuecomment-5674408397
> Thanks for updating. Some minor comments. Thanks @philo-he for the additional review. > I think the following test already guards the basic functionality of ColumnarPartialProject, so perhaps we can remove the above test. Sounds good removed that test > Perhaps, no need to keep the original test code as comment for reference. We can just leave a brief comment like: Gluten exception differs from Spark. Updated the comments, removed the spark code and just mentioned "Gluten exception differs from Spark" Please let me know if there is anything we want to update. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
