Copilot commented on code in PR #13085:
URL: https://github.com/apache/gluten/pull/13085#discussion_r4070072941
##########
.github/workflows/velox_backend_enhanced.yml:
##########
@@ -82,7 +82,14 @@ jobs:
build-native-lib-centos-8:
needs: detect-changes
runs-on: ubuntu-22.04
+ container: apache/gluten:vcpkg-almalinux-8-gcc13
steps:
+ - name: Install CI tools (temporary - until image is rebuilt with
gh/jq/bison/python3.9)
+ run: |
+ dnf install -y jq bison tzdata
+ dnf module -y install python39 && alternatives --set python3
/usr/bin/python3.9
+ dnf config-manager --add-repo
https://cli.github.com/packages/rpm/gh-cli.repo
+ dnf install -y gh --setopt=gpgcheck=0
Review Comment:
This disables RPM signature verification when installing `gh` as root in the
CI container, allowing a compromised repository or mirror to provide an
unverified executable. Keep GPG verification enabled and import/pin the GitHub
CLI signing key, or install `gh` from a trusted prebuilt image.
##########
.github/workflows/velox_backend_arm.yml:
##########
@@ -121,16 +121,16 @@ jobs:
uses:
apache/infrastructure-actions/stash/save@0ba14156c9f4c3cfbe4b0c9f36339ab0f8d81e53
with:
path: '${{ env.CCACHE_DIR }}'
- key: ccache-centos8-release-default-${{runner.arch}}-${{
hashFiles('ep/build-velox/src/**') }}
+ key: ccache-centos9-release-default-${{runner.arch}}-${{
hashFiles('ep/build-velox/src/**') }}
include-hidden-files: true
- uses: actions/upload-artifact@v7
with:
- name: velox-native-lib-centos-8-${{github.sha}}
+ name: velox-native-lib-centos-9-${{github.sha}}
path: ./cpp/build/releases/
if-no-files-found: error
tpc-test-centos8:
Review Comment:
This job now depends on the CentOS 9 build and downloads the CentOS 9
artifact, but its identifier still says `centos8`. Rename it to
`tpc-test-centos9` so workflow status names and future references describe the
platform being tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
