rdtr commented on issue #10134: URL: https://github.com/apache/gluten/issues/10134#issuecomment-5967065903
@PHILO-HE I went through the remaining items. A few can be checked off, could you update the checklist? Can be checked off: - Abs: done in https://github.com/facebookincubator/velox/pull/14346 (merged 2025-09-18). Spark's `abs` throws on integer overflow in ANSI mode, and the ANSI CI has no `abs` failures. - VAR_POP, VAR_SAMP, STDDEV_POP, STDDEV_SAMP: these have no ANSI behavior in Spark. Their final divisions are guarded by `If(n === 0.0, ...)`, and the result for a zero divisor (NULL or NaN) depends on `spark.sql.legacy.statisticalAggregate`, which Gluten already passes to Velox. - RoundCeil, RoundFloor: no ANSI behavior either (`RoundBase.ansiEnabled` is false; only `Round` and `BRound` override it). Offloading them is in progress in #12777. I've also proposed one direction for passing the ANSI mode to Velox in https://github.com/facebookincubator/velox/issues/3869, since several of these PRs depend on it. Please check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
