akshaytayal opened a new pull request, #13248:
URL: https://github.com/apache/gluten/pull/13248

   ## What changes are proposed in this pull request?
   
   Re-enables 9 Spark 4.2 tests that check NOT NULL enforcement:
   
   - `update with constraint violation and transactional checks` in 
`GlutenDeltaBasedUpdateTableSuite`, 
`GlutenDeltaBasedUpdateAsDeleteAndInsertTableSuite` and 
`GlutenGroupBasedUpdateTableSuite`
   - the 6 `SPARK-55716: V1 INSERT ...` NOT NULL tests in `GlutenInsertSuite`
   
   They expect a `SparkRuntimeException` when a null reaches a NOT NULL column. 
With Gluten, `AssertNotNull` runs in Velox 
(`velox/functions/sparksql/AssertNotNull.cpp`) and throws a `VeloxUserError` 
("Null value appeared in non-nullable field"), so the query fails with a 
`SparkException` instead.
   
   This commit only removes the 9 excludes. The fix will follow in this PR. The 
other #13175 tests need different fixes and are in #13244 (DELETE) and 
#__MERGE__ (MERGE).
   
   Part of #13175.
   
   ## How was this patch tested?
   
   Spark 4.2 UT CI (`spark-test-spark42` group 3 runs 
`org.apache.spark.sql.connector` and `org.apache.spark.sql.sources`).
   
   ## Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: GitHub Copilot CLI (Claude Opus 5.5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to