luis4a0 opened a new pull request, #13282: URL: https://github.com/apache/gluten/pull/13282
## What changes are proposed in this pull request? Separate Gluten companion for https://github.com/facebookincubator/velox/pull/19480. - Remove only the integral ROUND overlay registrations so they no longer shadow the upstream implementation. Floating-point overlays are unchanged. - Test the actual registered native implementation's HALF_UP ties, session ANSI overflow, legacy wrapping, TRY and NULL behavior. - Keep nonnegative integral scales in `[0, 400]` eligible for native execution. Typed NULL scales execute natively and skip child evaluation, including children that would otherwise overflow. - Negative and unqualified scales remain in Spark, even when general native validation is disabled. **Negative-scale SQL offload is intentionally not enabled here.** Spark captures ANSI mode in the expression, while a native session may have a different mode later. The fallback preserves that contract, including session changes before and after physical planning. No new function alias or per-call BOOLEAN argument is introduced. **Dependency:** `UPSTREAM_VELOX_PR_ID=19480` uses the existing developer hook for CI validation. Replace it with a qualified normal Velox dependency containing the upstream implementation before merging. ## How was this patch tested? - A native regression reproduced the old overlay returning `20` for `round(25, -1)` and failing to raise ANSI overflow. - The updated native scalar-function suite verifies the upstream registrations, including `30` for the same HALF_UP tie. - `VeloxIntegralRoundSuite` checks guards independently of the general native-validation switch. - `GlutenIntegralRoundSuite` checks all signed widths, native identity execution, negative-scale Spark fallback, ANSI overflow, legacy wrapping, captured-mode changes, NULL-scale child short-circuiting and extreme-scale fallback on Spark 4.1.1 with JDK 17 and JDK 21. ## Was this patch authored or co-authored using generative AI tooling? Generated-by: GitHub Copilot CLI 1.0.91 Co-authored by Luis Penaranda and GitHub Copilot CLI 1.0.91. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
