luis4a0 commented on code in PR #13282: URL: https://github.com/apache/gluten/pull/13282#discussion_r4269483738
########## ep/build-velox/src/get-velox.sh: ########## @@ -25,7 +25,7 @@ RUN_SETUP_SCRIPT=ON ENABLE_ENHANCED_FEATURES=OFF # Developer use only for testing Velox PR. -UPSTREAM_VELOX_PR_ID="" +UPSTREAM_VELOX_PR_ID="19480" Review Comment: Agreed for the merge-ready revision. This is an explicitly dependency-blocked validation companion, and the hook currently makes CI exercise https://github.com/facebookincubator/velox/pull/19480 rather than a stock dependency without those integral registrations. The PR description requires replacing it with a qualified normal dependency and restoring the empty hook before merging. An environment-only opt-in without updating CI would stop validating the required implementation. Keeping this thread open as the dependency/merge gate; the temporary setting is not proposed as a permanent default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
