malinjawi commented on PR #13165: URL: https://github.com/apache/gluten/pull/13165#issuecomment-6247504249
Thanks @felipepessoto. All three findings are confirmed and addressed: - P1 (1b486cca6): plans that call a counter now force `expression.eval_simplified=false` after user overrides. I added the regression you described. - Both P2s (7f5c7a3a0): the guard is now an allowlist of the parents Delta DML generates. Nullable ancestors, lambdas, conditions, AND/OR and everything else fall back. The description now has the scope statement. While checking I found one more gap, which already exists on main and which this PR does not change. Velox can push a hash-join dynamic filter below the projection that counts `numSourceRows`, so that metric can undercount for an inner-join MERGE with a broadcast target. Only that metric is affected; table rows and CDF are not. I noted it in the description and will raise it separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
