malinjawi commented on PR #13165: URL: https://github.com/apache/gluten/pull/13165#issuecomment-6247631554
Thanks @felipepessoto, all three are fixed: 1b486cca6 for eval_simplified, 7f5c7a3a0 for the placement guard. I also added the scope statement to the description. One more thing I noticed while reading the code, not reproduced yet: Velox can push a join filter below the numSourceRows counter, so that metric can undercount in some inner-join MERGEs. It's the same on main and isn't changed here, and table rows and CDF aren't affected. I'll raise it separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
