HwangDongJun commented on PR #12831: URL: https://github.com/apache/gluten/pull/12831#issuecomment-6394763738
@zhouyuan Following up on the Copilot review you requested: I changed two things in response and checked them (details in my replies on its threads). The call that exports SSL_CERT_FILE now sits at the beginning of VeloxBackend::init, and the OpenSSL default locations are read from the linked library instead of being hard coded. CI is green on the current head (75 checks, none failing). On the question in my earlier comment: I would keep the TlsTrustStore part, because without it Rocky 8.9 and AlmaLinux 8.10 images, which work today, hang after the triplet change. If you would rather not carry the native code, I can reduce the PR to the triplet change and document the /etc/ssl/cert.pem link (or SSL_CERT_FILE) for RHEL 8 images instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
