wud-if opened a new pull request, #13455: URL: https://github.com/apache/gluten/pull/13455
### What changes are proposed in this pull request? Fixes #13454 Maps the session-timezone date/time expressions to their velox flinksql implementations (companion velox PR bigo-sg/velox#88): - `RexCallConverterFactory`: `CURRENT_DATE` / `CURRENT_TIME` entries. - `LogicalTypeConverter`: Flink RowData represents TIME as INT (millisecond-of-day) — the same encoding the velox flinksql time functions use — so `TimeType` maps onto velox `INTEGER` and TIME columns cross the bridge unchanged. - `RexNodeConverter`: TIME literals convert to the millisecond-of-day `IntegerValue`. - `VeloxQueryConfig`: Flink's `local-time-zone` `default` means the JVM default timezone, not UTC — velox must resolve it the same way so CURRENT_DATE / CURRENT_TIME match native Flink. - `GlutenStreamingTestBase.runQuery`: returns the captured print rows without asserting, for tolerance-based checks on time-varying expressions. - CI routing: `flink.yml` / `Flink.md` temporarily clone the velox4j pin branch carrying the velox temporal branch; reverted once the velox PR merges. ### How was this patch tested? - Planner-level: TIME-literal conversion to millis-of-day `IntegerValue`; TIME in the typed-null carrier list. - Execution-level (embedded gluten stack): `current_date` epoch-day equality; `current_time` millis-of-day range + wall-clock proximity (±60s), and exact boolean comparisons against TIME literals (`CURRENT_TIME > TIME '00:00:01'`). - End-to-end dual-run on Flink 1.19.2: CURRENT_DATE value-equal (epoch-day rendering); CURRENT_TIME within ±2s tolerance under parallel submission; TIME-literal comparisons exact match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
