wud-if commented on PR #13455: URL: https://github.com/apache/gluten/pull/13455#issuecomment-6489991169
@ggjh-159 Thanks for the review! We chose to cover TIME typed nulls rather than drop the claim — pushed in https://github.com/apache/gluten/commit/7bd81925ba2af4301bb6685b6527dcd56c0a73a1: toVariant intercepts TIME null literals before the switch and falls back to the null-accepting VarCharValue carrier (the millis-of-day IntegerValue wraps a primitive int and cannot carry null, which is exactly where the NPE came from). On the velox side, the ConstantTypedExpr renders a null variant as a null constant of the expression type, and the serde treats an absent "value" member as the typed null — same mechanism as the other null carriers. Added RexNodeConverterTest.testTimeNullLiteralConvertsToNullCarrier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
