sunshone opened a new pull request, #13461: URL: https://github.com/apache/gluten/pull/13461
## What changes are proposed in this pull request? Fixes #13457 Extends `RexCallConverterFactory` with 4 direct name mappings via `DefaultRexCallConverter`: `NOT` → `not`, `IS FALSE` → `is_false`, `IS NOT TRUE` → `is_not_true`, `IS NOT FALSE` → `is_not_false`. These previously failed planning with "Function not supported". `IS TRUE` keeps its existing `IsTrueRexCallConverter` (unchanged). The mapped velox names are provided by the companion velox PR (today carried in the bigo-sg/velox fork used by the velox4j FLINK preset). `is_false` / `is_not_true` / `is_not_false` only exist there — landing order / version pairing needs maintainer input; `not` exists in the baseline and the companion PR registers a behavior-identical flinksql vector function under the same name. ## How was this patch tested? - **Maven**: `RexNodeConverterTest` 2/2; filter 8 run / 0 fail / 3 pre-existing skips; project 1/1. Spotless clean. - **e2e dual-run vs native Flink 1.19.2** (classpath-switched cluster, plan snapshots verify mode): 6 SQL cases, all FINISHED on both engines; 5/5 comparable exact-match after changelog folding — truth-table projections incl. NULL rows, `IS NOT TRUE` filters, planner-absorbed `NOT`, nested forms, boolean-family regression. One GROUP BY case excluded — pre-existing keyed-aggregation defect, reproduced identically before this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
