sunshone commented on code in PR #13461:
URL: https://github.com/apache/gluten/pull/13461#discussion_r4522170284
##########
gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/functions/RexCallConverterFactory.java:
##########
@@ -131,7 +131,12 @@ public class RexCallConverterFactory {
Map.entry("SHA512", Arrays.asList(() -> new
DefaultRexCallConverter("sha512"))),
Map.entry("count_char", Arrays.asList(() -> new
DefaultRexCallConverter("count_char"))),
Map.entry("EXTRACT", Arrays.asList(() -> new
DefaultRexCallConverter("extract"))),
- Map.entry("IS TRUE", Arrays.asList(() -> new
IsTrueRexCallConverter())),
Review Comment:
Good point — removed. `IsTrueRexCallConverter` was only referenced by the
`IS TRUE` map entry, which this PR already switches to
`DefaultRexCallConverter("is_true")`; a repo-wide search confirms no other
references, so the class would be dead code once the entry is replaced.
Verified with a full-chain compile of the planner/ut modules plus the test
suite: `LogicalFunctionsTest` 8/8 green, `ScalarFunctionsTest` regression 21
run / 0 failures (one pre-existing `@Disabled`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
