lgbo-ustc commented on code in PR #13473:
URL: https://github.com/apache/gluten/pull/13473#discussion_r4388728348
##########
gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/functions/RexCallConverterFactory.java:
##########
@@ -107,6 +107,18 @@ public class RexCallConverterFactory {
Map.entry("IS NULL", Arrays.asList(() -> new
DefaultRexCallConverter("isnull"))),
Map.entry(
"REGEXP_EXTRACT", Arrays.asList(() -> new
DefaultRexCallConverter("regexp_extract"))),
+ // Direct name mapping: both arities are covered by the flinksql
to_date signatures.
+ Map.entry("TO_DATE", Arrays.asList(() -> new
DefaultRexCallConverter("to_date"))),
Review Comment:
[P1] These new TO_DATE / TO_TIMESTAMP / TO_TIMESTAMP_LTZ mappings require
the flinksql registrations introduced by bigo-sg/velox#94. However, this PR
does not change .github/workflows/flink.yml, which still checks out
bigo-sg/velox4j at 26c7715278e6f6795084f6334998cb2ce382f7aa (lines 90-92). That
Velox4j revision reads src/main/cpp/velox-ref.txt and pins Velox to
aff6baab84d650cc22dd8b7cf1ab55f0ea52d929, which is 22 commits behind the #94
head (6aa6b617f45365bde843dcdf4546a7eb602e2f17) and has no
TemporalFunctionsRegistration.cpp. Please update the Velox4j Velox ref to a
commit containing #94, publish the corresponding Velox4j revision, and pin that
Velox4j revision in this PRs Flink workflow. Otherwise the new planner
expressions will reach a native engine without these functions and fail at
execution; the current CI build cannot validate the feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
