TianJialong commented on code in PR #13473:
URL: https://github.com/apache/gluten/pull/13473#discussion_r4408526814


##########
gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/functions/RexCallConverterFactory.java:
##########
@@ -107,6 +107,18 @@ public class RexCallConverterFactory {
           Map.entry("IS NULL", Arrays.asList(() -> new 
DefaultRexCallConverter("isnull"))),
           Map.entry(
               "REGEXP_EXTRACT", Arrays.asList(() -> new 
DefaultRexCallConverter("regexp_extract"))),
+          // Direct name mapping: both arities are covered by the flinksql 
to_date signatures.
+          Map.entry("TO_DATE", Arrays.asList(() -> new 
DefaultRexCallConverter("to_date"))),

Review Comment:
   @lgbo-ustc Thanks for the review! Pushed 157cb39 (Additionally, some test 
cases were added), please check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to