LuciferYang commented on code in PR #13287:
URL: https://github.com/apache/gluten/pull/13287#discussion_r4397162617
##########
gluten-ut/spark41/src/test/scala/org/apache/spark/sql/GlutenCachedTableSuite.scala:
##########
@@ -31,12 +31,10 @@ class GlutenCachedTableSuite
with GlutenSQLTestsTrait
with AdaptiveSparkPlanHelper {
import testImplicits._
- // for temporarily disable the columnar table cache globally.
- sys.props.put(GlutenConfig.COLUMNAR_TABLE_CACHE_ENABLED.key, "true")
- override def sparkConf: SparkConf = {
- super.sparkConf.set("spark.sql.shuffle.partitions", "5")
- super.sparkConf.set(GlutenConfig.COLUMNAR_TABLE_CACHE_ENABLED.key, "true")
- }
+ override def sparkConf: SparkConf =
+ super.sparkConf
+ .set("spark.sql.shuffle.partitions", "5")
Review Comment:
The spark42 copy of `GlutenCachedTableSuite` still has the old code.
`gluten-ut/spark42` landed on main after this branch was cut and only came in
through a later merge, so lines 35-38 there still do `sys.props.put` and two
separate `super.sparkConf.set(...)` calls. The 4.2 `VeloxTestSettings` enables
this suite, so after merge it keeps running with 1 shuffle partition on Spark
4.2, and #12861 would be closed with that copy still broken.
Could you apply the same change to spark42 and add spark42 to the Affects
list in the description? `spark-test-spark42` is skipped on this PR because
none of the changed paths trigger it; touching `gluten-ut/spark42/` will.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
