sabbasani commented on code in PR #13287:
URL: https://github.com/apache/gluten/pull/13287#discussion_r4397538475
##########
gluten-ut/spark41/src/test/scala/org/apache/spark/sql/GlutenCachedTableSuite.scala:
##########
@@ -31,12 +31,10 @@ class GlutenCachedTableSuite
with GlutenSQLTestsTrait
with AdaptiveSparkPlanHelper {
import testImplicits._
- // for temporarily disable the columnar table cache globally.
- sys.props.put(GlutenConfig.COLUMNAR_TABLE_CACHE_ENABLED.key, "true")
- override def sparkConf: SparkConf = {
- super.sparkConf.set("spark.sql.shuffle.partitions", "5")
- super.sparkConf.set(GlutenConfig.COLUMNAR_TABLE_CACHE_ENABLED.key, "true")
- }
+ override def sparkConf: SparkConf =
+ super.sparkConf
+ .set("spark.sql.shuffle.partitions", "5")
Review Comment:
Done — applied the same fix to
gluten-ut/spark42/src/test/scala/org/apache/spark/sql/GlutenCachedTableSuite.scala
and updated the Affects: line in the commit message to include spark42. The
file now uses the chained super.sparkConf form with no sys.props.put, matching
the spark34/35/40/41 copies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
