wud-if commented on PR #13455: URL: https://github.com/apache/gluten/pull/13455#issuecomment-6599298705
> Thanks for the update. Looks good. Could you check whether the CI failure is related? @philo-he Thanks! The CI problems are unrelated to this PR — details below. The 5 remaining errors are not from this PR: GlutenStreamTwoInputWatermarkStatusTest (4 errors: "StreamJoin is not yet migrated to operator-owned keyed state; there is no state handler to initialize") and NexmarkTest (1 error: same for "GroupWindowAggregator") — both NOT_IMPLEMENTED from velox's experimental/stateful, introduced by the stateful key-hash-collision change (https://github.com/apache/gluten/issues/79) that is part of the current upstream velox head this PR's stack builds on. Any arithmetic-containing velox revision contains it (the arithmetic squash sits on top of https://github.com/apache/gluten/issues/79), so the pin cannot avoid it. All arithmetic-expression tests are green in this run: RoundFunctionsTest 4/4, AbsFunctionsTest 3/3, FloorCeilFunctionsTest 4/4, UnaryMinusFunctionsTest 2/2, ArithmeticDualRunSqlTest 4/4, RexCallConverterFactoryTest 8/8 (132 tests total: 0 failures, 5 errors — all the stateful ones above, 5 skipped). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
