ggjh-159 commented on code in PR #13455:
URL: https://github.com/apache/gluten/pull/13455#discussion_r4480619135
##########
gluten-flink/ut/src/test/java/org/apache/gluten/table/runtime/stream/common/GlutenStreamingTestBase.java:
##########
@@ -191,7 +200,7 @@ protected void runAndCheck(String query, List<String>
expected) {
result.add(line);
}
}
- assertThat(result).isEqualTo(expected);
+ return result;
Review Comment:
Assertions should not be removed here.
##########
.github/workflows/flink.yml:
##########
@@ -73,6 +73,8 @@ jobs:
run: |
source /opt/rh/gcc-toolset-12/enable
sudo dnf install -y patchelf ccache
+ # The distro patchelf fails with "maximum file size
+ # exceeded" on the ~260MB libvelox.so; use a modern static build.
Review Comment:
This comment may not need to be added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]